fix: improve styling for list page and accordion view#5252
fix: improve styling for list page and accordion view#5252another-rex merged 2 commits intogoogle:masterfrom
Conversation
ashmod
changed the title
michaelkedar
left a comment
michaelkedar
left a comment
There was a problem hiding this comment.
I like it, though I'm wondering if there's a way to keep the red accent colour somehow (or red text on black is just always bad contrast)
|
I've tried out a few other combinations before I went with the white on black, one of the options would be light red on black, because osv-red wouldn't have the best contrast here: 
I also tried white on red: 
but colors felt too vibrant I guess. 
and toning down the red did not help much either. I eventually went with the current palette because it felt easier on the eyes, but lmk what you think. |
|
Thanks for the alternative screenshots, I think I'm still a fan of the current gray and red, maybe we can make the red text darker for better contrast? |
Yeah I think a lighter gray + darker red could work better too. Will look into this in the follow up. |
Follow up on #5252 Adds back the red accent to accordion headers by using darker red text on a lighter gray. **(Before)** <img width="2038" height="1158" alt="image" src="https://github.com/user-attachments/assets/2ed3f6f6-2be4-41b1-b7d2-8cb1e1732d9d" /> **(After)** <img width="2061" height="1154" alt="image" src="https://github.com/user-attachments/assets/0cce2541-b19a-42f2-96e7-e0af8d9aba23" /> Also noticed an issue with the "Introduced" field value being white in light mode, so this was fixed too.
3 participants
Applies some tiny improvements for styling after light-mode implementation
Fixes 'Published' sort arrow icon visibility in dark mode on the /list page:
(Before)
(After)
Fixes accordion open state styling in light mode with proper background/text contrast:
(Before)
(After)
Also, unrelated to theming, reduced the tree structure ending line distance from last child item in accordion view because it looked too spacious.